Skip to content

Conversation

@mzuber
Copy link
Contributor

@mzuber mzuber commented Apr 29, 2025

Summary

The latest version of the paketo-buildpacks/poetry buildpack introduced support for the new Poetry major version 2 (see paketo-buildpacks/poetry#473). Integration tests in #1027 are failing due to the Poetry build descriptors in the tests missing or using deprecated configuration options:

[builder] The "poetry.dev-dependencies" section is deprecated and will be removed in a future version. Use "poetry.group.dev.dependencies" instead.
[builder] If you want to use Poetry only for dependency management but not for packaging, you can disable package mode by setting package-mode = false in your pyproject.toml file.

This PR prepares the Poetry build descriptors to be compatible with Poetry version 2.

Note to reviewers: Trying to run the integration tests by simply executing the test script with ./scripts/integration.sh fails if no additional script flags are used. The small change to the scripts/package.sh script deals with that.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@mzuber mzuber requested a review from a team as a code owner April 29, 2025 14:14
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 29, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@sgaist sgaist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzuber mzuber force-pushed the prepare-integration-tests-for-poetry-v2 branch from 5106ccd to 7f14bc0 Compare May 5, 2025 06:56
@mzuber mzuber requested a review from jericop May 5, 2025 15:19
@jericop jericop added the semver:patch A change requiring a patch version bump label May 5, 2025
@jericop jericop merged commit 4638a14 into paketo-buildpacks:main May 5, 2025
8 of 9 checks passed
@jericop
Copy link
Contributor

jericop commented May 5, 2025

Thanks for this PR! Your contribution is very much appreciated.

@mzuber mzuber deleted the prepare-integration-tests-for-poetry-v2 branch May 6, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patch A change requiring a patch version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants